Preserve structured Jacobian cache storage during initialization - #4072
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
CI audit after completion:
Local execution on the exact PR patch did reach the relevant tests: the focused structured-Jacobian initialization regression passed, and the official DiffEqBase Downstream target |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
fill!on the logical matrixDiagonal,Bidiagonal,Tridiagonal,SymTridiagonal, andUpperTriangularprototypes, includinginit/solve!coverage for diagonal and tridiagonal cachesRoot cause
A clean-master bisect identified
d8cbb9e4446427305484e25eb4c81c9f85c09277(Initialize sparse Jacobian caches with stored values (#3833)) as the first bad commit. That change correctly avoided initializing sparse structural entries to zero, but routed every non-sparse prototype throughfill!.fill!(::Diagonal, one(...))attempts to write structural zeros outside the stored diagonal and throws.The implementation uses public structured-array interfaces and the public backing storage of structured wrappers.
SymTridiagonalrequires a constructor/copyto!specialization because its publicsetindex!rejects off-diagonal writes even at stored positions.Local verification
default_linsolve_structure.jlon Julia 1.12.6: exit 0GROUP=Downstreamtarget testset:Default linsolve with structure | Pass 28 | Broken 2 | Total 30callback_detection.jlordering assertions (lines 53 and 58); kept out of this branch for a separate clean-master investigationgit diff --check: exit 0lib/OrdinaryDiffEqCore/src/disco.jl,lib/OrdinaryDiffEqCore/src/integrators/controllers.jl, andtest/Integrators_I/disco_tests.jl